chore!: remove leftovers from when virtuals were symlinks

.yarn/versions/8773ddfe.yml

@@ -0,0 +1,32 @@
+releases:
+  "@yarnpkg/core": major
+  "@yarnpkg/plugin-pnp": major
+  "@yarnpkg/pnp": major
+
+declined:
+  - "@yarnpkg/esbuild-plugin-pnp"
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-http"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-node-modules"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/cli"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/pnpify"

packages/acceptance-tests/pkg-tests-core/sources/utils/makeTemporaryEnv.ts

@@ -45,8 +45,6 @@ const mte = generatePkgDriver({
         [`YARN_ENABLE_TELEMETRY`]: `0`,
         // Otherwise snapshots relying on this would break each time it's bumped
         [`YARN_CACHE_KEY_OVERRIDE`]: `0`,
-        // Otherwise the tests would break when C:\tmp is on a different drive than the repo
-        [`YARN_ENABLE_ABSOLUTE_VIRTUALS`]: `true`,
         // Otherwise the output isn't stable between runs
         [`YARN_ENABLE_TIMERS`]: `false`,
         [`YARN_ENABLE_PROGRESS_BARS`]: `false`,

packages/gatsby/static/configuration/yarnrc.json

@@ -103,12 +103,6 @@
       "format": "uri-reference",
       "default": "./.yarn/versions"
     },
-    "enableAbsoluteVirtuals": {
-      "_package": "@yarnpkg/core",
-      "description": "If true, the virtual symlinks will use absolute (non-portable!) paths if required.",
-      "type": "boolean",
-      "default": false
-    },
     "enableColors": {
       "_package": "@yarnpkg/core",
       "description": "If true (by default detects terminal capabilities), Yarn will format its pretty-print its output by using colors to differentiate important parts of its messages.",

packages/plugin-pnp/sources/PnpLinker.ts

@@ -204,8 +204,6 @@ export class PnpInstaller implements Installer {
 
 
   async finalizeInstall() {
-    const blacklistedPaths = new Set<PortablePath>();
-
     for (const {locator, location} of this.virtualTemplates.values()) {
       miscUtils.getMapWithDefault(this.packageRegistry, structUtils.stringifyIdent(locator)).set(locator.reference, {
         packageLocation: location,
@@ -222,7 +220,6 @@ export class PnpInstaller implements Installer {
 
     const pnpFallbackMode = this.opts.project.configuration.get(`pnpFallbackMode`);
 
-    const blacklistedLocations = blacklistedPaths;
     const dependencyTreeRoots = this.opts.project.workspaces.map(({anchoredLocator}) => ({name: structUtils.stringifyIdent(anchoredLocator), reference: anchoredLocator.reference}));
     const enableTopLevelFallback = pnpFallbackMode !== `none`;
     const fallbackExclusionList = [];
@@ -237,7 +234,6 @@ export class PnpInstaller implements Installer {
           fallbackExclusionList.push({name: structUtils.stringifyIdent(pkg), reference: pkg.reference});
 
     await this.finalizeInstallWithPnp({
-      blacklistedLocations,
       dependencyTreeRoots,
       enableTopLevelFallback,
       fallbackExclusionList,

packages/yarnpkg-core/sources/Configuration.ts

@@ -211,11 +211,6 @@ export const coreDefinitions: {[coreSettingName: string]: SettingsDefinition} =
     type: SettingsType.BOOLEAN,
     default: false,
   },
-  enableAbsoluteVirtuals: {
-    description: `If true, the virtual symlinks will use absolute paths if required [non portable!!]`,
-    type: SettingsType.BOOLEAN,
-    default: false,
-  },
 
   // Settings related to the output style
   enableColors: {
@@ -501,7 +496,6 @@ export interface ConfigurationValueMap {
   immutablePatterns: Array<string>;
   rcFilename: Filename;
   enableGlobalCache: boolean;
-  enableAbsoluteVirtuals: boolean;
 
   enableColors: boolean;
   enableHyperlinks: boolean;

packages/yarnpkg-pnp/sources/generateSerializedState.ts

@@ -1,4 +1,4 @@
-import {LocationBlacklistData, PackageRegistryData}     from './types';
+import {PackageRegistryData}                            from './types';
 import {PackageStoreData, PnpSettings, SerializedState} from './types';
 
 // Keep this function is sync with its implementation in:
@@ -96,10 +96,6 @@ function generatePackageRegistryData(settings: PnpSettings): PackageRegistryData
   return packageRegistryData;
 }
 
-function generateLocationBlacklistData(settings: PnpSettings): LocationBlacklistData {
-  return sortMap(settings.blacklistedLocations || [], location => location);
-}
-
 export function generateSerializedState(settings: PnpSettings): SerializedState {
   return {
     // @eslint-ignore-next-line @typescript-eslint/naming-convention
@@ -116,7 +112,6 @@ export function generateSerializedState(settings: PnpSettings): SerializedState
 
     fallbackExclusionList: generateFallbackExclusionList(settings),
     fallbackPool: generateFallbackPoolData(settings),
-    locationBlacklistData: generateLocationBlacklistData(settings),
     packageRegistryData: generatePackageRegistryData(settings),
   };
 }

packages/yarnpkg-pnp/sources/loader/hydrateRuntimeState.ts

@@ -14,7 +14,7 @@ export function hydrateRuntimeState(data: SerializedState, {basePath}: HydrateRu
     ? new RegExp(data.ignorePatternData)
     : null;
 
-  const packageLocatorsByLocations = new Map<PortablePath, {locator: PhysicalPackageLocator, discardFromLookup: boolean} | null>();
+  const packageLocatorsByLocations = new Map<PortablePath, {locator: PhysicalPackageLocator, discardFromLookup: boolean}>();
   const packageLocationLengths = new Set<number>();
 
   const packageRegistry = new Map<string | null, PackageStore>(data.packageRegistryData.map(([packageName, packageStoreData]) => {
@@ -57,9 +57,6 @@ export function hydrateRuntimeState(data: SerializedState, {basePath}: HydrateRu
     }))];
   }));
 
-  for (const location of data.locationBlacklistData)
-    packageLocatorsByLocations.set(location, null);
-
   const fallbackExclusionList = new Map(data.fallbackExclusionList.map(([packageName, packageReferences]) => {
     return [packageName, new Set(packageReferences)] as [string, Set<string>];
   }));

packages/yarnpkg-pnp/sources/loader/internalTools.ts

@@ -2,7 +2,6 @@ import {Path, npath} from '@yarnpkg/fslib';
 
 export enum ErrorCode {
   API_ERROR = `API_ERROR`,
-  BLACKLISTED = `BLACKLISTED`,
   BUILTIN_NODE_RESOLUTION_FAILED = `BUILTIN_NODE_RESOLUTION_FAILED`,
   MISSING_DEPENDENCY = `MISSING_DEPENDENCY`,
   MISSING_PEER_DEPENDENCY = `MISSING_PEER_DEPENDENCY`,
@@ -15,7 +14,6 @@ export enum ErrorCode {
 // Some errors are exposed as MODULE_NOT_FOUND for compatibility with packages
 // that expect this umbrella error when the resolution fails
 const MODULE_NOT_FOUND_ERRORS = new Set([
-  ErrorCode.BLACKLISTED,
   ErrorCode.BUILTIN_NODE_RESOLUTION_FAILED,
   ErrorCode.MISSING_DEPENDENCY,
   ErrorCode.MISSING_PEER_DEPENDENCY,

packages/yarnpkg-pnp/sources/loader/makeApi.ts

@@ -505,38 +505,13 @@ export function makeApi(runtimeState: RuntimeState, opts: MakeApiOptions): PnpAp
 
     for (let t = from; t < packageLocationLengths.length; ++t) {
       const entry = packageLocatorsByLocations.get(relativeLocation.substr(0, packageLocationLengths[t]) as PortablePath);
-      if (typeof entry === `undefined`)
-        continue;
-
-      // Ensures that the returned locator isn't a blacklisted one.
-      //
-      // Blacklisted packages are packages that cannot be used because their dependencies cannot be deduced. This only
-      // happens with peer dependencies, which effectively have different sets of dependencies depending on their
-      // parents.
-      //
-      // In order to deambiguate those different sets of dependencies, the Yarn implementation of PnP will generate a
-      // symlink for each combination of <package name>/<package version>/<dependent package> it will find, and will
-      // blacklist the target of those symlinks. By doing this, we ensure that files loaded through a specific path
-      // will always have the same set of dependencies, provided the symlinks are correctly preserved.
-      //
-      // Unfortunately, some tools do not preserve them, and when it happens PnP isn't able anymore to deduce the set of
-      // dependencies based on the path of the file that makes the require calls. But since we've blacklisted those
-      // paths, we're able to print a more helpful error message that points out that a third-party package is doing
-      // something incompatible!
-
-      if (entry === null) {
-        const locationForDisplay = getPathForDisplay(location);
-        throw makeError(
-          ErrorCode.BLACKLISTED,
-          `A forbidden path has been used in the package resolution process - this is usually caused by one of your tools calling 'fs.realpath' on the return value of 'require.resolve'. Since we need to use symlinks to simultaneously provide valid filesystem paths and disambiguate peer dependencies, they must be passed untransformed to 'require'.\n\nForbidden path: ${locationForDisplay}`,
-          {location: locationForDisplay},
-        );
-      }
 
-      if (entry.discardFromLookup && !includeDiscardFromLookup)
-        continue;
+      if (typeof entry !== `undefined`) {
+        if (entry.discardFromLookup && !includeDiscardFromLookup)
+          continue;
 
-      return entry.locator;
+        return entry.locator;
+      }
     }
 
     return null;
@@ -622,9 +597,6 @@ export function makeApi(runtimeState: RuntimeState, opts: MakeApiOptions): PnpAp
           unqualifiedPath = ppath.normalize(ppath.join(ppath.dirname(absoluteIssuer), request));
         }
       }
-
-      // No need to use the return value; we just want to check the blacklist status
-      findPackageLocator(unqualifiedPath);
     } else {
       // Things are more hairy if it's a package require - we then need to figure out which package is needed, and in
       // particular the exact version for the given location on the dependency tree

packages/yarnpkg-pnp/sources/types.ts

@@ -32,7 +32,6 @@ export type PackageStoreData = Array<[string | null, PackageInformationData<Port
 export type PackageRegistry = Map<string | null, PackageStore>;
 export type PackageRegistryData = Array<[string | null, PackageStoreData]>;
 
-export type LocationBlacklistData = Array<PortablePath>;
 export type LocationLengthData = Array<number>;
 
 // This is what is stored within the .pnp.meta.json file
@@ -43,7 +42,6 @@ export type SerializedState = {
   fallbackExclusionList: Array<[string, Array<string>]>,
   fallbackPool: Array<[string, DependencyTarget]>,
   ignorePatternData: string | null,
-  locationBlacklistData: LocationBlacklistData,
   packageRegistryData: PackageRegistryData,
   dependencyTreeRoots: Array<PhysicalPackageLocator>,
 };
@@ -56,17 +54,13 @@ export type RuntimeState = {
   fallbackPool: Map<string, DependencyTarget>,
   ignorePattern: RegExp | null,
   packageLocationLengths: Array<number>,
-  packageLocatorsByLocations: Map<PortablePath, {locator: PhysicalPackageLocator, discardFromLookup: boolean} | null>;
+  packageLocatorsByLocations: Map<PortablePath, {locator: PhysicalPackageLocator, discardFromLookup: boolean}>;
   packageRegistry: PackageRegistry,
   dependencyTreeRoots: Array<PhysicalPackageLocator>,
 };
 
 // This is what the generation functions take as parameter
 export type PnpSettings = {
-  // Some locations that are not allowed to make a require call, period
-  // (usually the realpath of virtual packages)
-  blacklistedLocations?: Iterable<PortablePath>,
-
   // Whether the top-level dependencies should be made available to all the
   // dependency tree as a fallback (default is true)
   enableTopLevelFallback?: boolean,