-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse options ending with 3+ hyphens #434
Conversation
Before this commit, options ending with three or more hyphens were being parsed as positional arguments, because a regular expression didn't have a start anchor. Closes yargs#433
This comment was marked as outdated.
This comment was marked as outdated.
@0x2b3bfa0 this fix looks good to me, but I believe you've created your PR against the branch |
@bcoe, It looks like this pull request should be safe to merge (?) |
Continuous integration checks are red. Is it my fault, or just a transient issue? 🤔 |
@0x2b3bfa0 It's not immediately clear to me what the regression might be, it might not be related to your code changes -- unfortunately it might be a little while until I can fix up tests. Apologies for the delay on review. |
@0x2b3bfa0 thank you for the patch 🥳 apologies for the slow turn around. |
Thank you very much! |
Options ending with three or more hyphens were being parsed as positional arguments because the
options without key name
regular expression didn't have a^
beginning anchor.