feat: add fallback for window width #45
Merged
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxrimue I'll work on landing this this weekend, managed to lose track of it 👍 |
bcoe
requested changes
Dec 1, 2016
| @@ -310,7 +310,7 @@ module.exports = function (opts) { | |||
| opts = opts || {} | |||
|
|
|||
| return new UI({ | |||
| width: (opts || {}).width || 80, | |||
| width: (opts || {}).width || process.stdout.columns || 80, | |||
There was a problem hiding this comment.
I think some folks run yargs in the browser, so process/process.stdout might not exist. Let's pull this into a helper method that looks something like this:
function defaultWidth () {
width = null
if (process && process.stdout && process.stdout.columns) width = process.stdout.columns
return width
}
maxrimue
force-pushed
the
feat/fallback
branch
from
50b8269 to
4b16b35
Compare
bcoe
approved these changes
Jan 17, 2017
| @@ -282,6 +282,10 @@ function _minWidth (col) { | |||
| return minWidth | |||
| } | |||
|
|
|||
| function getWindowWidth () { | |||
| if (process && process.stdout && process.stdout.columns) return process.stdout.columns | |||
There was a problem hiding this comment.
super small nit, let's go with typeof process === 'object', rather than just checking if process is truthy. Otherwise, this is looking great.
|
looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little fallback which returns the window width of the current window when no width is passed using the API.
If this PR gets merged, we could just not pass any width to cliui in yargs instead of requiring the rather expensive
window-size.