fix(#195): provide default values for concatenatedProperties #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated the code to use |
RustyToms
changed the title
|
If this fixes #195, can this be reviewed and merged? |
|
Thanks @RustyToms! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #195
This issue affects IE 11 which is still being supported for quite some time. It seems somehow to be related to emberjs/ember.js#14264 , though that particular issue was fixed. @PrzemoRevolve found a work around, but instead of adding empty strings for the concatenated properties every time modal-dialog is used, the work around can be implemented inside basic-dialog.js by adding default values of empty arrays to those properties.
@lukemelia this works on IE 11,
do you think it will cause any unwanted side effects?with null values instead of empty arrays (which I tried first) I don't think it should cause any side effects.