Safer click target check

yapplabs · Mar 3, 2018 · 984a155 · 984a155
1 parent 8d78c1e
commit 984a155
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/addon/components/basic-dialog.js b/addon/components/basic-dialog.js
@@ -70,7 +70,8 @@ export default Component.extend({
       }
 
       // if the click is within the dialog, do nothing
-      if (document.querySelector(modalSelector).contains(target)) {
+      let modalEl = document.querySelector(modalSelector);
+      if (modalEl && modalEl.contains(target)) {
         return;
       }