Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for example maps and edge cases #60

Open
yaph opened this issue Nov 4, 2019 · 0 comments
Open

Add tests for example maps and edge cases #60

yaph opened this issue Nov 4, 2019 · 0 comments

Comments

@yaph
Copy link
Owner

yaph commented Nov 4, 2019

The goal is to create tests for common use cases, as well as edge cases that should work with d3-geomap. For example missing values in a CSV file should not cause errors that stop the map from rendering.

To add a new test:

  1. Pick a map from the examples directory, that has no tests yet.
  2. Create a JavaScript file in the tests directory with the same name.
  3. Write code that tests what the example is meant to show, e.g. if the example shows how to add a custom legend, the test should at least check its visibility.

Take a look at the existing tests for additional guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant