Switch to C++14 #144
Open
Switch to C++14 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdigiglio
reviewed
Apr 14, 2017
| } | ||
|
|
||
| /// check if first container contains second (no sorting necessary). | ||
| /// BinaryPredicate must have signature bool(const InputIt1::type&, const InputIt2::type&) | ||
| template <class InputIt1, class InputIt2, class BinaryPredicate> | ||
| bool contains(InputIt1 first_haystack, InputIt1 last_haystack, InputIt2 first_needle, InputIt2 last_needle, BinaryPredicate p) | ||
| { | ||
| return std::all_of(first_needle, last_needle, [&](const typename std::iterator_traits<InputIt2>::value_type& b) | ||
| return std::all_of(first_needle, last_needle, [&](const auto& b) | ||
| {return std::any_of(first_haystack, last_haystack, std::bind(p, std::placeholders::_1, b)); }); |
There was a problem hiding this comment.
The std::bind can be replaced by a lambda:
{ return std::any_of(first_haystack, last_haystack, [&](const auto& a) { return p(a, b); }); });
pdigiglio
reviewed
Apr 14, 2017
| @@ -227,12 +227,12 @@ bool DecayChannel::consistent() const | |||
| bool C = true; | |||
|
|
|||
| // check no daughters is empty | |||
| if (std::any_of(Daughters_.begin(), Daughters_.end(), [](std::shared_ptr<Particle> d) {return !d;})) { | |||
| if (std::any_of(Daughters_.begin(), Daughters_.end(), [](auto d) {return !d;})) { | |||
There was a problem hiding this comment.
Copying a shared_ptr is expensive, I'd pass it by const reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.