Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install rules #110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Install rules #110

wants to merge 4 commits into from

Conversation

pdigiglio
Copy link
Contributor

make install installs the header files in ${CMAKE_INSTALL_PREFIX}/include/YAP with rw-r--r-- permissions, and the shared library libYAP.so in ${CMAKE_INSTALL_PREFIX}/lib with rwxr-xr-x permissions.

Optionally a DESTDIR can be specified at installation-time:

$ make DESTDIR=/home/my_user install

This will install the files in ${DESTDIR}/${CMAKE_INSTALL_PREFIX}.

@greenwald Which permissions should the data/ files have when installed?

@greenwald
Copy link
Contributor

make the data permissions the same as the include permissions.

@pdigiglio
Copy link
Contributor Author

Should the install target set the YAPDIR environment variable?

It might be useful to have

export YAPDIR=${CMAKE_INSTALL_PREFIX}

I think we shouldn't rely on environment variables (thus we should change the examples and the tests).

@greenwald
Copy link
Contributor

We should exclude the installation of the data files from the full installation (which should only install the headers and lib). Perhaps a custom target, install-data is the best and easiest way to go for the moment.

@greenwald
Copy link
Contributor

So what are the targets that will be available. I gather there will be

  • make install-core
  • make install-data

But will there also be make install (which should perform the same function as make install-core)? If not, please add it. At the base, what we require is:

  • make install (installs the library and headers)
  • make install-data (installs the data file)

@pdigiglio
Copy link
Contributor Author

There is

  • make install: installs everything;
  • make install/local: I didn't get what it is;
  • make install/strip: I didn't get what it is;
  • make install-core: installs libYAP.so and headers;
  • make install-data: installs the data directory.

I wasn't able to default install to install-core nor to suppress the first three (automatically generated) install rules.

@greenwald
Copy link
Contributor

And there's no way to create our own separate target install-data to install the data and to therefore exclude it from the install target?

Another option would be to somehow exclude the action in install-data if the install location is /usr/local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants