Skip to content

Fix: discussion answer parent id type #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

Fix: discussion answer parent id type #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion githubkit/versions/ghec_v2022_11_28/models/group_0525.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class WebhooksAnswer(GitHubModel):
html_url: str = Field()
id: int = Field()
node_id: str = Field()
parent_id: None = Field()
parent_id: Union[int, None] = Field()
reactions: Missing[WebhooksAnswerPropReactions] = Field(
default=UNSET, title="Reactions"
)
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/ghec_v2022_11_28/types/group_0525.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class WebhooksAnswerType(TypedDict):
html_url: str
id: int
node_id: str
parent_id: None
parent_id: Union[int, None]
reactions: NotRequired[WebhooksAnswerPropReactionsType]
repository_url: str
updated_at: datetime
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/v2022_11_28/models/group_0458.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class WebhooksAnswer(GitHubModel):
html_url: str = Field()
id: int = Field()
node_id: str = Field()
parent_id: None = Field()
parent_id: Union[int, None] = Field()
reactions: Missing[WebhooksAnswerPropReactions] = Field(
default=UNSET, title="Reactions"
)
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/v2022_11_28/types/group_0458.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class WebhooksAnswerType(TypedDict):
html_url: str
id: int
node_id: str
parent_id: None
parent_id: Union[int, None]
reactions: NotRequired[WebhooksAnswerPropReactionsType]
repository_url: str
updated_at: datetime
Expand Down
1 change: 1 addition & 0 deletions githubkit/versions/versions.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ source = "https://raw.githubusercontent.com/github/rest-api-description/dee4dc2b
"/components/schemas/webhook-workflow-run-requested/properties/workflow_run/properties/pull_requests/items/properties/id" = {type = "integer"}
"/components/schemas/webhook-workflow-run-requested/properties/workflow_run/properties/pull_requests/items/properties/number" = {type = "integer"}
"/webhooks/repository-dispatch-sample.collected/post" = {operationId = "repository-dispatch"}
"/components/schemas/webhooks_answer/properties/parent_id" = {type = ["integer", "null"]}
"/components/schemas/dependabot-alert-with-repository/properties/dependency/properties/relationship/enum" = {"<add>" = ["inconclusive"]}
"/components/schemas/code-scanning-alert-classification/enum" = {"<add>" = ["documentation"]}

Expand Down
7 changes: 7 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,13 @@ source = "descriptions-next/ghec/ghec.2022-11-28.json"
"/webhooks/repository-dispatch-sample.collected/post" = { operationId = "repository-dispatch" }
# "/components/schemas/webhook-repository-dispatch-sample/properties/action" = { enum = "<unset>" }

# https://github.com/yanyongyu/githubkit/issues/239
# discussion answer's parent id may be not null
"/components/schemas/webhooks_answer/properties/parent_id" = { type = [
"integer",
"null",
] }

# https://github.com/yanyongyu/githubkit/issues/205
# https://github.com/github/rest-api-description/issues/4727
"/components/schemas/dependabot-alert-with-repository/properties/dependency/properties/relationship/enum" = { "<add>" = [
Expand Down