[Fix] boolean-prop-naming: handle React.FC, intersection, union types

[mobily]

Types of changes

This PR fixes #3197, therefore, the boolean-prop-naming rule validates correctly the following code:

import type { FC } from 'react' // or import { FC } from 'react'

type Props = {
  enabled: boolean // ❌ error
} 

export const Component: FC<Props> = props => { 
  return <div /> 
}

import * as React from 'react' 

type Props = {
  enabled: boolean // ❌ error
} 

export const Component: React.FC<Props> = props => { 
  return <div /> 
}

import type { FC } from 'react' // or import { FC } from 'react'

type Props = {
  isEnabled: boolean // ✅
} 

export const Component: FC<Props> = props => { 
  return <div /> 
}

import * as React from 'react' 

type Props = {
  isEnabled: boolean // ✅
} 

export const Component: React.FC<Props> = props => { 
  return <div /> 
}

Moreover, previously, the plugin could not handle a case like this:

import * as React from 'react'
import { BoxProps } from '@mobily/stacks'

type Props = {
  isEnabled: boolean, // ⬅️ this was completely ignored
} & BoxProps

export const Component = (props: Props) => { 
  return <div /> 
}

or

import * as React from 'react'

type Props = {
  isEnabled: boolean, 
} & {
  lol: boolean, // ⬅️ same here, both property types were ignored
}

export const Component = (props: Props) => { 
  return <div /> 
}

Now, the plugin handles the intersection and union types as well, so the following will be validated correctly:

import * as React from 'react'

type Props = {
  isEnabled: boolean, // ✅
} & {
  lol: boolean, // ❌ error
}

export const Component = (props: Props) => { 
  return <div /> 
}

import * as React from 'react'

type Props = {
  isEnabled: boolean, // ✅
} | {
  lol: boolean, // ❌ error
}

export const Component = (props: Props) => { 
  return <div /> 
}

import * as React from 'react'

type Props = {
  isEnabled: boolean, // ✅
} & ({
  lol: boolean, // ❌ error
} | {
  hasLOL: boolean, // ✅
})

export const Component = (props: Props) => { 
  return <div /> 
}

[ljharb]

Thanks, this is great!

[mobily]

@ljharb and in the meantime, I have added a logic that handles the union type as well, I'm looking forward to your review!

[ljharb]

Seems great!

[ljharb]

hmm, looks like the latest changes you pushed up (or, possibly, my tiny tweaks, but i doubt it) are failing some tests. can you take a look?

[codecov-commenter]

Codecov Report

Merging #3241 (b59417f) into master (cdfd558) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3241   +/-   ##
=======================================
  Coverage   97.68%   97.69%           
=======================================
  Files         121      121           
  Lines        8520     8550   +30     
  Branches     3076     3096   +20     
=======================================
+ Hits         8323     8353   +30     
  Misses        197      197           

Impacted Files	Coverage Δ
lib/rules/boolean-prop-naming.js	99.40% <100.00%> (+0.13%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfd558...b59417f. Read the comment docs.

[mobily]

✅ and done, thanks, @ljharb for tweaking my code a bit!

edit: not yet 😅

[mobily]

@ljharb ok, I think the most important cases have been handled, could you please run all test suites once again?

[mobily]

thank you @ljharb ❤️