[Fix] no-unused-state: avoid a crash on a class field gDSFP

Fixes #3236.
jsx-eslint · Mar 6, 2022 · cdfd558 · cdfd558
1 parent 24bf594
commit cdfd558
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`no-unused-state`]: avoid a crash on a class field gDSFP ([#3236][] @ljharb)
+
+[#3236]: https://github.com/yannickcr/eslint-plugin-react/issues/3236
+
 ## [7.29.3] - 2022.03.03
 
 ### Fixed

diff --git a/lib/rules/no-unused-state.js b/lib/rules/no-unused-state.js
@@ -249,6 +249,7 @@ module.exports = {
         !node.static
         || name !== 'getDerivedStateFromProps'
         || !node.value
+        || !node.value.params
         || node.value.params.length < 2 // no `state` argument
       ) {
         return false;

diff --git a/tests/lib/rules/no-unused-state.js b/tests/lib/rules/no-unused-state.js
@@ -1052,6 +1052,18 @@ eslintTester.run('no-unused-state', rule, {
         }
       `,
       features: ['types'],
+    },
+    {
+      code: `
+        export const commonMixinWrapper = ComposeComponent => class extends ComposeComponent {
+          static getDerivedStateFromProps = ComposeComponent.getDerivedStateFromProps;
+          render() { return <div />; }
+        }
+      `,
+      features: ['class fields'],
+      parserOptions: {
+        sourceType: 'module',
+      },
     }
   )),