types.hとtypes.cppで冗長なコードを整理し、空白やインデントを微調整 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KazApps
commented
Jul 29, 2024
•
KazApps
commented
- d1 ? d1 == Effect8::directions_of(sq2, sq3) : falseをd1 && d1 == Effect8::directions_of(sq2, sq3)に式を簡略化。
- std::string((pc & 32) ? "D":"") ではstring型にする必要はないため、(pc & 32) ? "D":""に変更。
- FOUND:;の不要なセミコロンを削除。
- 空白やインデントを微調整。
KazApps
changed the title
KazApps
changed the title
KazApps
changed the title
これ不要ではあるんですが、C/C++の文法上、ラベル: のあと、statementが来ないといけなくて、例えば、ブロックの末尾であるような場合などで、statementが来てなくてエラーとなるのが気持ち悪くて、おまじないのように必ず入れてあります。(gotoしたいラベルを置きたい場所はたいていブロックの末尾なので..) なのでこれは消さないでいただきたいです。 |
|
そんな事情があったんですね... |
|
プルリクありがとうございました🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.