Fix bug with reload HBA #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaUnisikhin
force-pushed
the
hba_fix
branch
from
c81581a
to
4b2ba46
Compare
reshke
reviewed
Mar 24, 2024
sources/system.c
Outdated
| @@ -511,7 +511,7 @@ void od_system_config_reload(od_system_t *system) | |||
| } | |||
|
|
|||
| od_config_free(&config); | |||
| od_hba_rules_free(&hba_rules); | |||
| // od_hba_rules_free(&hba_rules); | |||
There was a problem hiding this comment.
Never comment code, delete it.
When old hba rules are deallocated?
|
We need test on this |
NikitaUnisikhin
force-pushed
the
hba_fix
branch
5 times, most recently
from
b61e3b2
to
284171d
Compare
NikitaUnisikhin
force-pushed
the
hba_fix
branch
3 times, most recently
from
db1029e
to
bedc2d4
Compare
x4m
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- reproduce (https://github.com/aidekqz/odyssey_test)