Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): min version required by pdf.js #11

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

marcofaggian
Copy link
Contributor

Hi there, nice work so far!

Just a small PR for upping the min version of node required to start the dev script.

Briefly: PDF.js is requiring Node 22

Reference: https://stackoverflow.com/questions/78415681/pdf-js-pdfjs-dist-promise-withresolvers-is-not-a-function

@yamalight
Copy link
Owner

Ah, good catch! Thanks!
I'm mostly using bun so haven't tested it with node much. Should probably also setup some tests for this 😅

@yamalight yamalight merged commit ac023b9 into yamalight:main Oct 7, 2024
@yamalight yamalight mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants