Fix issue with pipeline name save and errors during execution

yamalight · Oct 16, 2024 · d994877 · d994877
1 parent e995baf
commit d994877
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/app/components/pipeline/nodes/output/OutputNode.tsx b/app/components/pipeline/nodes/output/OutputNode.tsx
@@ -79,13 +79,18 @@ export function OutputNode() {
   }, [litlytics, pipeline]);
 
   const doRunPipeline = async () => {
-    const newPipeline = await litlytics.runPipeline({
-      onStatus: (status) => setPipelineStatus(status),
-    });
-    setPipeline(newPipeline);
+    try {
+      const newPipeline = await litlytics.runPipeline({
+        onStatus: (status) => setPipelineStatus(status),
+      });
+      setPipeline(newPipeline);
 
-    // write final status to update on end
-    setPipelineStatus({ status: 'done' });
+      // write final status to update on end
+      setPipelineStatus({ status: 'done' });
+    } catch (err) {
+      console.error('Error executing pipeline', err);
+      setPipelineStatus({ status: 'error' });
+    }
   };
 
   const running =

diff --git a/app/components/pipeline/nodes/source/SourceNode.tsx b/app/components/pipeline/nodes/source/SourceNode.tsx
@@ -47,7 +47,7 @@ export function SourceNode() {
   const source = useMemo(() => {
     return pipeline.source;
   }, [pipeline.source]);
-  const docs = useMemo(() => source.docs, [source.docs]);
+  const docs = useMemo(() => source.docs ?? [], [source.docs]);
 
   const sourceType = useMemo(
     () => ((source.config as SourceConfig)?.type ?? 'text') as SourceType,

diff --git a/app/components/ui/Overlay.tsx b/app/components/ui/Overlay.tsx
@@ -340,7 +340,9 @@ export function OverlayUI() {
                 placeholder="Pipeline name"
                 autoFocus
                 value={pipeline.name}
-                onChange={(e) => (pipeline.name = e.target.value)}
+                onChange={(e) =>
+                  setPipeline({ ...pipeline, name: e.target.value })
+                }
               />
             </Field>
           </FieldGroup>