Skip to content

fix: Remove 'requires' field from marketplace.json#898

Merged
yamadashy merged 1 commit intoyamadashy:mainfrom
ramarivera:fixes/claude-code-marketplace
Oct 17, 2025
Merged

fix: Remove 'requires' field from marketplace.json#898
yamadashy merged 1 commit intoyamadashy:mainfrom
ramarivera:fixes/claude-code-marketplace

Conversation

@ramarivera
Copy link
Copy Markdown
Contributor

This pull request makes a minor update to the .claude-plugin/marketplace.json configuration file by removing the unnecessary requires field from the plugin definition. This simplifies the plugin metadata without affecting functionality.

Fixes #897

Removed 'requires' field from marketplace.json.
Copilot AI review requested due to automatic review settings October 16, 2025 02:06
@ramarivera ramarivera requested a review from yamadashy as a code owner October 16, 2025 02:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unnecessary requires field from the .claude-plugin/marketplace.json configuration file to simplify the plugin metadata without affecting functionality.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ramarivera, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the plugin's configuration by eliminating the 'requires' field from the '.claude-plugin/marketplace.json' file. This modification aims to simplify the metadata structure, ensuring a cleaner and more concise plugin definition without any impact on its operational functionality. It directly addresses a reported issue to improve maintainability.

Highlights

  • Plugin Metadata Simplification: The 'requires' field has been removed from the '.claude-plugin/marketplace.json' file, streamlining the plugin's metadata.
  • No Functional Impact: This change is a minor update that simplifies the configuration without affecting the plugin's functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

Removed the requires: ["repomix-mcp"] field from the repomix-commands plugin entry in .claude-plugin/marketplace.json. The strict: false field remains unchanged.

Changes

Cohort / File(s) Summary
Marketplace manifest
.\claude-plugin/marketplace.json
Deleted the property requires: ["repomix-mcp"] from the "name": "repomix-commands" plugin object; no other fields modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provides a concise summary of the change and references the related issue but does not include the required “## Checklist” section with entries for running tests and linting as specified by the repository template. Please add the “## Checklist” section to the description with entries for “npm run test” and “npm run lint” to satisfy the repository’s required template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change by indicating the removal of the ‘requires’ field from the marketplace.json file without including unnecessary details.
Linked Issues Check ✅ Passed The changes remove the unsupported ‘requires’ field from .claude-plugin/marketplace.json exactly as described in issue #897, thereby resolving the schema validation error during the marketplace add operation.
Out of Scope Changes Check ✅ Passed All modifications are limited to removing the ‘requires’ field from the marketplace manifest, which directly aligns with the linked issue and does not introduce any unrelated or extraneous changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c118c9 and 6be6bb8.

📒 Files selected for processing (1)
  • .claude-plugin/marketplace.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the requires field from the .claude-plugin/marketplace.json file, simplifying the plugin's metadata. The change is straightforward and implemented correctly. I have no suggestions for improvement.

@ramarivera
Copy link
Copy Markdown
Contributor Author

Hey hey @yamadashy 👋🏻
Is there anything else I could do on my side to move this fwd, or its just a matter of waiting till you have some capacity here :)

@yamadashy
Copy link
Copy Markdown
Owner

Hi @ramarivera!

Sorry for the delay! Thank you so much for creating this PR.

I didn't notice this issue while I was experimenting with the plugin setup.
Everything looks good, so I'll merge it now. Thanks for taking care of this!

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.66%. Comparing base (7c118c9) to head (6be6bb8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   74.66%   74.66%           
=======================================
  Files         109      109           
  Lines        7653     7653           
  Branches     1433     1433           
=======================================
  Hits         5714     5714           
  Misses       1939     1939           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yamadashy yamadashy merged commit 2391c6f into yamadashy:main Oct 17, 2025
48 of 49 checks passed
@ramarivera
Copy link
Copy Markdown
Contributor Author

Thanks for the speedy review and merge!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marketplace error "unrecognized key(s) in object requires"

3 participants