-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(core): Improve error handling and performance optimizations #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ae68e51
fix(core): optimize worker thread allocation
yamadashy 47d8a79
perf(core): Add timing measurement for Tinypool initialization
yamadashy 6eb8f27
refactor(core): Replace environment variable with workerData for work…
yamadashy 7f7d487
fix(core): Handle workerData as array in setLogLevelByWorkerData
yamadashy f51bf40
refactor(core): Improve worker logger initialization positioning and …
yamadashy f09ca52
refactor(core): Extract TokenCounter management to factory with multi…
yamadashy 002bea3
refactor(core): Rename handleOutput to writeOutputToDisk for clarity
yamadashy de3e18d
feat(shared): Add ErrorOptions support to RepomixError classes
yamadashy 2f3c891
fix(core): Handle 'Invalid string length' error with user-friendly me…
yamadashy 6290ec9
fix(core): Improve error message to mention both --include and --igno…
yamadashy 4b4fb4e
fix(core): Improve 'Invalid string length' error message with clearer…
yamadashy 287ccea
fix(shared): Show stack trace only in debug mode for RepomixError
yamadashy 3468504
feat(core): Show largest files in 'Invalid string length' error message
yamadashy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import type { TiktokenEncoding } from 'tiktoken'; | ||
| import { TokenCounter } from './TokenCounter.js'; | ||
|
|
||
| // Worker-level cache for TokenCounter instances by encoding | ||
| const tokenCounters = new Map<TiktokenEncoding, TokenCounter>(); | ||
|
|
||
| /** | ||
| * Get or create a TokenCounter instance for the given encoding. | ||
| * This ensures only one TokenCounter exists per encoding per worker thread to optimize memory usage. | ||
| */ | ||
| export const getTokenCounter = (encoding: TiktokenEncoding): TokenCounter => { | ||
| let tokenCounter = tokenCounters.get(encoding); | ||
| if (!tokenCounter) { | ||
| tokenCounter = new TokenCounter(encoding); | ||
| tokenCounters.set(encoding, tokenCounter); | ||
| } | ||
| return tokenCounter; | ||
| }; | ||
|
|
||
| /** | ||
| * Free all TokenCounter resources and clear the cache. | ||
| * This should be called when the worker is terminating. | ||
| */ | ||
| export const freeTokenCounter = (): void => { | ||
| for (const tokenCounter of tokenCounters.values()) { | ||
| tokenCounter.free(); | ||
| } | ||
| tokenCounters.clear(); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logger import is missing from this file. This will cause a runtime error when TokenCounter is instantiated.