chore: drop node 16 as it is EOL#225
chore: drop node 16 as it is EOL#225yamadashy merged 1 commit intoyamadashy:mainfrom chenrui333:drop-node-16
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
|
📝 WalkthroughWalkthroughThe pull request introduces changes to the project's Node.js version compatibility. The CI workflow configuration and Changes
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant CI as GitHub Actions
participant Node as Node.js Runtime
Dev->>CI: Push code
CI->>Node: Select Node.js version
Note over CI,Node: Versions: 18.x, 20.x, 22.x, 23.x
CI->>CI: Run tests
CI->>CI: Build project
CI->>Dev: Report results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 44 44
Lines 2058 2058
Branches 450 450
=======================================
Hits 1895 1895
Misses 163 163 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/ci.yml (1)
Line range hint
143-143: Critical: Node.js 16.x needs to be removed from build-and-run jobThe build-and-run job still includes Node.js 16.x in its version matrix, which is inconsistent with:
- The package.json engine requirement of ">=18.0.0"
- The test job's version matrix
- The PR objective to drop Node.js 16 support
This will cause CI failures as the build job attempts to run with an unsupported Node.js version.
Apply this fix:
matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [16.x, 18.x, 20.x, 22.x, 23.x] + node-version: [18.x, 20.x, 22.x, 23.x]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
.github/workflows/ci.yml(1 hunks)package.json(1 hunks)
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
95-95: LGTM on test job Node.js versions
The update to remove Node.js 16.x from the test matrix is appropriate.
|
Hi, @chenrui333 ! You're right, Node.js 16 has reached its EOL. I initially kept it in the supported list because Repomix technically worked on it, but considering the security risks and overall maintenance, it's time to drop the support. This will be better for the project in the long run. Thanks again for pointing this out and for creating the PR. |
|
@chenrui333 Hope to see more contributions from you in the future! |
2 participants
Checklist
npm run testnpm run lint