ci(perf): Track perf/auto-perf-tuning benchmarks on separate gh-pages page#1449
ci(perf): Track perf/auto-perf-tuning benchmarks on separate gh-pages page#1449
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe performance benchmark history workflow is now configured to trigger on pushes to the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⚡ Performance Benchmark
Details
History7d39815 ci(perf): Track perf/auto-perf-tuning benchmarks on separate gh-pages page
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 117 117
Lines 4435 4435
Branches 1022 1022
=======================================
Hits 3868 3868
Misses 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/perf-benchmark-history.yml (1)
5-13: Scope concurrency by branch to avoid serializing runs across branchesThe static
concurrency.groupat Line 12 will serialize all workflow runs across bothmainandperf/auto-perf-tuningbranches. This can blockmainbranch updates when the experimental branch is active. Scope the concurrency group by branch reference instead:Suggested change
concurrency: - group: perf-benchmark-history + group: perf-benchmark-history-${{ github.ref }} cancel-in-progress: false🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/perf-benchmark-history.yml around lines 5 - 13, The static concurrency.group "perf-benchmark-history" serializes runs across branches; update the concurrency.group to include the branch reference so runs are scoped per branch (e.g., change concurrency.group to perf-benchmark-history-${{ github.ref_name }} or similar) and keep cancel-in-progress: false; edit the concurrency block (the concurrency.group symbol) so it uses the GitHub context variable (github.ref_name or github.ref) to avoid cross-branch serialization.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/perf-benchmark-history.yml:
- Around line 5-13: The static concurrency.group "perf-benchmark-history"
serializes runs across branches; update the concurrency.group to include the
branch reference so runs are scoped per branch (e.g., change concurrency.group
to perf-benchmark-history-${{ github.ref_name }} or similar) and keep
cancel-in-progress: false; edit the concurrency block (the concurrency.group
symbol) so it uses the GitHub context variable (github.ref_name or github.ref)
to avoid cross-branch serialization.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 26ecbc0c-96c4-489f-9de0-c35e99ccd6a8
📒 Files selected for processing (1)
.github/workflows/perf-benchmark-history.yml
Code ReviewVerdict: Approve ✅ Clean, minimal CI change that correctly isolates One suggestion: scope the concurrency group by branchThe concurrency group Consider scoping the group by branch: concurrency:
group: perf-benchmark-history-${{ github.ref_name }}
cancel-in-progress: falseThis lets each branch run independently without blocking the other. Low severity since benchmarks aren't on the critical path, but a nice improvement. Detailed review notes
🤖 Generated with Claude Code |
Deploying repomix with
|
| Latest commit: |
a0b6397
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://25fb312a.repomix.pages.dev |
| Branch Preview URL: | https://ci-perf-benchmark-auto-perf.repomix.pages.dev |
… page Trigger the performance benchmark history workflow on pushes to perf/auto-perf-tuning in addition to main, and publish its results to a dedicated gh-pages directory so the chart lives independently from main's history. Why: perf/auto-perf-tuning is an experimental branch that gets force-pushed, and we want to observe its performance over time without disturbing the main performance dashboard at dev/bench/. How to apply: the name and benchmark-data-dir-path passed to github-action-benchmark are now branched on github.ref: - main -> "Repomix Performance" under dev/bench/ (unchanged) - perf/auto-perf-tuning -> "Repomix Performance (auto-perf-tuning)" under dev/bench/auto-perf-tuning/ Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yamadashy
force-pushed
the
ci/perf-benchmark-auto-perf-tuning
branch
from
7d39815 to
a0b6397
Compare
|
Thanks for the suggestion from both @claude and @coderabbitai re: scoping the concurrency group by branch. Leaving this as-is intentionally. The serialization is by design: both branches push to the same |
|
Claude finished @yamadashy's task in 37s —— View job That makes perfect sense — I hadn't considered the |
|
Tip For best results, initiate chat on the files or code changes.
✏️ Learnings added
🧠 Learnings used |
1 participant
Summary
perf/auto-perf-tuningin addition tomain.perf/auto-perf-tuningresults to a dedicateddev/bench/auto-perf-tuning/directory ongh-pagesso it renders as an independent page —main's existing dashboard atdev/bench/stays untouched.github.reffor bothnameandbenchmark-data-dir-pathpassed tobenchmark-action/github-action-benchmark.Resulting URLs
main: https://yamadashy.github.io/repomix/dev/bench/ (unchanged)perf/auto-perf-tuning: https://yamadashy.github.io/repomix/dev/bench/auto-perf-tuning/ (new, auto-created on first run)Why a separate page
perf/auto-perf-tuningis an experimental branch that gets force-pushed, so mixing its commits intomain's historical chart would make the timeline hard to read. Isolating it into its own data directory keeps the two histories completely independent — the data files (data.js) do not share state, so neither branch's runs can disturb the other's chart.Checklist
🤖 Generated with Claude Code