Skip to content

fix(metrics): Use resolveEncodingAsync for bundler-compatible token counting #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamadashy merged 3 commits into from
Apr 6, 2026
+7 −3
Merged

fix(metrics): Use resolveEncodingAsync for bundler-compatible token counting #1417

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9958a1
fix(website): Add gpt-tokenizer to external deps for server bundle
yamadashy Apr 6, 2026
a1b9e03
refactor(metrics): Use static import map for gpt-tokenizer encodings
yamadashy Apr 6, 2026
8bcd93a
refactor(metrics): Delegate encoding resolution to gpt-tokenizer's re…
yamadashy Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/core/metrics/TokenCounter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { GptEncoding } from 'gpt-tokenizer/GptEncoding';
import { resolveEncodingAsync } from 'gpt-tokenizer/resolveEncodingAsync';
import { logger } from '../../shared/logger.js';

// Supported token encoding types (OpenAI encoding names)
Expand Down Expand Up @@ -25,9 +27,11 @@ const loadEncoding = async (encodingName: TokenEncoding): Promise<CountTokensFn>

const startTime = process.hrtime.bigint();

// Dynamic import of the specific encoding module from gpt-tokenizer
const mod = await import(`gpt-tokenizer/encoding/${encodingName}`);
const countFn = mod.countTokens as CountTokensFn;
// Use resolveEncodingAsync to lazily load BPE rank data, then create a GptEncoding instance.
// resolveEncodingAsync uses static import paths internally, so bundlers (rolldown) can resolve them.
const bpeRanks = await resolveEncodingAsync(encodingName);
const encoder = GptEncoding.getEncodingApi(encodingName, () => bpeRanks);
const countFn = encoder.countTokens.bind(encoder) as CountTokensFn;
encodingModules.set(encodingName, countFn);

const endTime = process.hrtime.bigint();
Expand Down
Loading