Conversation
…tolink GitHub auto-links 7+ char commit SHAs in PR comments, but wrapping them in <code> HTML tags prevented this. Remove the tags so SHAs become clickable links automatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
⚡ Performance Benchmark
Details
History362a8eb fix(perf-benchmark): Make regex backwards-compatible with old <code> format
86a4208 ci(perf-benchmark): Remove <code> tags from commit SHAs for GitHub autolink
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughRemoved Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
=======================================
Coverage 87.13% 87.13%
=======================================
Files 116 116
Lines 4393 4393
Branches 1020 1020
=======================================
Hits 3828 3828
Misses 565 565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying repomix with
|
| Latest commit: |
d256318
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e38a88e.repomix.pages.dev |
| Branch Preview URL: | https://ci-bench-comment-autolink-co.repomix.pages.dev |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/scripts/perf-benchmark/bench-pending.mjs (1)
15-15: Backward compatibility: First run after merge may not archive previous result.The updated regex expects the new format (SHA without
<code>tags), but the existing PR comment will still have the old format with<code>tags. During the first workflow run after this PR merges, the regex won't match the old format, so that benchmark result won't be archived into history.This is likely acceptable as a one-time migration cost, but worth noting. Alternatively, you could make the
<code>wrapper optional in the regex:🔧 Optional: Make regex backward-compatible
- const commitMatch = mainSection.match(/Latest commit:<\/strong><\/td><td>([a-f0-9]+)\s*(.*?)<\/td>/); + const commitMatch = mainSection.match(/Latest commit:<\/strong><\/td><td>(?:<code>)?([a-f0-9]+)(?:<\/code>)?\s*(.*?)<\/td>/);This makes the
<code>tags optional, allowing parsing of both old and new formats.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/scripts/perf-benchmark/bench-pending.mjs at line 15, The regex in bench-pending.mjs that builds commitMatch currently only matches the new SHA format and will miss older PR comments that wrapped the SHA in <code> tags; update the regular expression used for commitMatch (the /Latest commit:<\/strong><\/td><td>([a-f0-9]+)\s*(.*?)<\/td>/ pattern) to make an optional <code>...</code> wrapper around the SHA (e.g., allow optional <code> before and </code> after the capture) so both old and new formats are accepted and the previous result will be parsed and archived.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/scripts/perf-benchmark/bench-pending.mjs:
- Line 15: The regex in bench-pending.mjs that builds commitMatch currently only
matches the new SHA format and will miss older PR comments that wrapped the SHA
in <code> tags; update the regular expression used for commitMatch (the /Latest
commit:<\/strong><\/td><td>([a-f0-9]+)\s*(.*?)<\/td>/ pattern) to make an
optional <code>...</code> wrapper around the SHA (e.g., allow optional <code>
before and </code> after the capture) so both old and new formats are accepted
and the previous result will be parsed and archived.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4abe255b-801c-4786-91f1-8982e7f866c5
📒 Files selected for processing (3)
.github/scripts/perf-benchmark/bench-comment.mjs.github/scripts/perf-benchmark/bench-pending.mjs.github/scripts/perf-benchmark/bench-utils.mjs
…format Make <code> tags optional in the commit SHA regex so existing benchmark comments with the old format are still parsed correctly during transition. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code ReviewClean, minimal PR. No new issues found beyond what was already identified and fixed.
Note on other bot reviewsBoth CodeRabbit and Gemini flagged the backwards compatibility issue with the regex in LGTM 👍 🤖 Generated with Claude Code |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove
<code>HTML tags wrapping commit SHAs in perf benchmark PR comments so that GitHub's autolink feature can recognize and link them automatically.Checklist
npm run testnpm run lint