fix(ci): Disable cancel-in-progress for perf benchmark by yamadashy · Pull Request #1349 · yamadashy/repomix

yamadashy · 2026-03-28T15:31:35Z

Disable cancel-in-progress in the perf benchmark workflow so that running benchmark jobs are not cancelled when new commits are pushed to the same PR. Queued runs will now wait for the in-progress run to complete.

Checklist

Run npm run test
Run npm run lint

Prevent running benchmark jobs from being cancelled when new commits are pushed to the same PR. Queued runs will now wait instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

gemini-code-assist · 2026-03-28T15:31:41Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

coderabbitai · 2026-03-28T15:31:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 789bfac5-8998-434c-81b3-da0ee48803b4

📥 Commits

Reviewing files that changed from the base of the PR and between bd9f343 and 98e8558.

📒 Files selected for processing (1)

.github/workflows/perf-benchmark.yml

📝 Walkthrough

Walkthrough

Modified the GitHub Actions workflow configuration to prevent cancellation of in-progress performance benchmark jobs when new runs are triggered for the same PR concurrency group by setting cancel-in-progress to false.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow Configuration `.github/workflows/perf-benchmark.yml`	Changed concurrency `cancel-in-progress` setting from `true` to `false` for the perf-benchmark concurrency group, allowing in-progress jobs to complete instead of being canceled by subsequent runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

ci(benchmark): Add performance benchmark workflow for PRs #1252: Directly modifies the same workflow file and changes the same concurrency group's cancel-in-progress setting.
perf(ci): Improve benchmark stability with interleaved execution #1348: Modifies .github/workflows/perf-benchmark.yml with workflow restructuring and script extraction changes.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: disabling cancel-in-progress for the perf benchmark workflow.
Description check	✅ Passed	The description includes a clear summary of changes and the checklist section is properly completed with both items checked.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/perf-benchmark-no-cancel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-28T15:32:17Z

⚡ Performance Benchmark

Latest commit:	`98e8558` fix(ci): Disable cancel-in-progress for perf benchmark workflow
Status:	✅ Benchmark complete!
Ubuntu:	2.00s (±0.02s) → 2.00s (±0.02s) · -0.00s (-0.2%)
macOS:	1.13s (±0.45s) → 1.16s (±0.28s) · +0.03s (+2.7%)
Windows:	2.27s (±0.04s) → 2.27s (±0.04s) · -0.01s (-0.3%)

Details

Packing the repomix repository with node bin/repomix.cjs
Warmup: 2 runs (discarded), interleaved execution
Measurement: 20 runs / 30 on macOS (median ± IQR)
Workflow run

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

claude · 2026-03-28T15:33:29Z

Review by Claude

Verdict: Approve ✅

This is a clean, well-scoped 1-line change that switches cancel-in-progress from true to false in the perf benchmark workflow.

Details

Analysis

The change is correct and well-motivated. Performance benchmarks need to run to completion to produce meaningful results. Cancelling an in-progress benchmark when a new commit is pushed wastes the compute already spent and delays feedback — the new run starts from scratch anyway.

With cancel-in-progress: false, queued runs wait for the current one to finish, which is the right behavior for benchmarks that:

Take significant time (up to 15min timeout, running across 3 OS matrices)
Produce artifacts that are only useful if the full run completes
Post results as PR comments (partial results would be misleading)

No concerns found across all review dimensions:

Security: No new permissions, secrets, or external actions introduced
Performance: This actually improves resource efficiency by avoiding wasted partial runs
Code quality: Minimal, focused change with clear commit message
Conventions: Follows the project's conventional commit format (fix(ci): ...)

Minor observation

The concurrency group is scoped per PR number (perf-benchmark-${{ github.event.pull_request.number }}), which means different PRs still run independently — only multiple pushes to the same PR queue up. This is the ideal behavior.

🤖 Generated with Claude Code

codecov · 2026-03-28T15:33:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.13%. Comparing base (bd9f343) to head (98e8558).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1349   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         116      116           
  Lines        4393     4393           
  Branches     1020     1020           
=======================================
  Hits         3828     3828           
  Misses        565      565

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cloudflare-workers-and-pages · 2026-03-28T15:34:10Z

Deploying repomix with Cloudflare Pages

Latest commit:	`98e8558`
Status:	✅ Deploy successful!
Preview URL:	https://775d1fed.repomix.pages.dev
Branch Preview URL:	https://fix-perf-benchmark-no-cancel.repomix.pages.dev

View logs

fix(ci): Disable cancel-in-progress for perf benchmark workflow

98e8558

Prevent running benchmark jobs from being cancelled when new commits are pushed to the same PR. Queued runs will now wait instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

devin-ai-integration bot reviewed Mar 28, 2026

View reviewed changes

coderabbitai bot approved these changes Mar 28, 2026

View reviewed changes

yamadashy merged commit 3e1fc1a into main Mar 28, 2026
63 checks passed

yamadashy deleted the fix/perf-benchmark-no-cancel branch March 28, 2026 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ci): Disable cancel-in-progress for perf benchmark#1349

fix(ci): Disable cancel-in-progress for perf benchmark#1349
yamadashy merged 1 commit intomainfrom
fix/perf-benchmark-no-cancel

yamadashy commented Mar 28, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

gemini-code-assist bot commented Mar 28, 2026

Uh oh!

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

github-actions bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

claude bot commented Mar 28, 2026

Analysis

Minor observation

Uh oh!

codecov bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

yamadashy commented Mar 28, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

gemini-code-assist bot commented Mar 28, 2026

Uh oh!

coderabbitai bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

github-actions bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Performance Benchmark

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

claude bot commented Mar 28, 2026

Review by Claude

Analysis

Minor observation

Uh oh!

codecov bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cloudflare-workers-and-pages bot commented Mar 28, 2026

Deploying repomix with Cloudflare Pages

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

yamadashy commented Mar 28, 2026 •

edited by devin-ai-integration bot

Loading

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

github-actions bot commented Mar 28, 2026 •

edited

Loading

codecov bot commented Mar 28, 2026 •

edited

Loading