Skip to content

fix: Allow markdown as valid option in configuration #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamadashy merged 2 commits into from
Oct 15, 2024
Merged

fix: Allow markdown as valid option in configuration #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e15167
fix: Allow markdown as valid option in configuration
r-dh Oct 15, 2024
c7709ad
Fix: Update configValidate.test.ts to reflect new markdown support
r-dh Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/config/configValidate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ export function validateConfig(config: unknown): asserts config is RepopackConfi
if (typeof style !== 'string') {
throw new RepopackConfigValidationError('output.style must be a string');
}
if (style !== 'plain' && style !== 'xml') {
throw new RepopackConfigValidationError('output.style must be either "plain" or "xml"');
if (style !== 'plain' && style !== 'xml' && style !== 'markdown') {
throw new RepopackConfigValidationError('output.style must be either "plain", "xml" or "markdown"');
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/config/configValidate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ describe('configValidate', () => {
test('should throw for invalid output.style value', () => {
const invalidConfig = { output: { style: 'invalid' } };
expect(() => validateConfig(invalidConfig)).toThrow(RepopackConfigValidationError);
expect(() => validateConfig(invalidConfig)).toThrow('output.style must be either "plain" or "xml"');
expect(() => validateConfig(invalidConfig)).toThrow('output.style must be either "plain", "xml" or "markdown"');
});
});