fix(cli): remove hardcoded white color from CLI output#1088
Conversation
Summary of ChangesHello @yamadashy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience of the command-line interface by eliminating instances of hardcoded white text in its output. By allowing the terminal to render text using its default foreground color, the changes significantly improve readability, especially for users who prefer or are required to use light-themed terminal environments where white text on a light background would be unreadable. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughRemoves color formatting from CLI report output by replacing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying repomix with
|
| Latest commit: |
69e117b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16308b70.repomix.pages.dev |
| Branch Preview URL: | https://fix-cli-report-white-color.repomix.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the visibility issue of CLI output on light-themed terminals by removing hardcoded pc.white() calls. The changes are consistent across the cliReport.ts file and the corresponding tests are updated correctly. I've added a few suggestions to improve the formatting of lists for better alignment and consistency, which is a minor enhancement made possible by these changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 87.16% 87.17%
=======================================
Files 116 116
Lines 4379 4382 +3
Branches 1019 1019
=======================================
+ Hits 3817 3820 +3
Misses 562 562 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code Review: PR #1088 - fix(cli): remove hardcoded white color from CLI outputSummaryThis PR fixes visibility issues on light-themed terminals (e.g., Solarized Light) by removing Verdict: ✅ LGTM - Approve Detailed AnalysisCode QualityThe changes are clean and focused. The PR removes 26 lines of Consistency CheckI verified that
Test CoverageTests are properly updated to match the new expected output format. The mock for Premortem AnalysisPotential Failure Scenarios & Mitigations
Minor Observations
No blocking issues found. This is a well-scoped fix that improves accessibility for users with light-themed terminals. |
Remove pc.white() calls from cliReport.ts to use terminal's default foreground color instead. This fixes visibility issues on light-themed terminals like Solarized Light where white text is unreadable. Closes #1057
Use padEnd(3) consistently across all list outputs for better alignment.
760cb5d to
69e117b
Compare
Follow-up Review: PR #1088I noticed an additional commit was pushed since my last review:
This is a good style improvement that complements the main fix. The consistent padding ensures proper alignment when listing items (suspicious files, binary files, top files, git security issues). Verdict: ✅ Still LGTM Updated ObservationsThe new commit applies consistent formatting across 4 places in
All use the same pattern: This ensures consistent formatting for lists 1-9 (single digit) vs 10+ (double digit). No new concerns. Ready to merge. |
Add release notes for v1.11.1 covering: - Multi-root directory labels (#1024) - Non-interactive skill generation options (#1022) - Remote git command timeout fix (#1078) - CLI output visibility fix for light themes (#1088) - Library bundling documentation (#1075) Improve release note generation guidelines: - Clarify "What's New" vs "Improvements" usage - Add rule to include related issue numbers with PRs - Add rule to include links in documentation sections
Remove
pc.white()calls from cliReport.ts to use the terminal's default foreground color instead.This fixes visibility issues on light-themed terminals like Solarized Light where white text becomes unreadable against a light background.
Closes #1057
Light mode
Dark mode
Checklist
npm run testnpm run lint