fix(ci): Improve Claude issue triage to preserve existing labels#1043
fix(ci): Improve Claude issue triage to preserve existing labels#1043
Conversation
Add instructions to check for existing labels before adding new ones and explicitly prohibit removing existing labels.
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
📝 WalkthroughWalkthroughThe Claude issue-triage GitHub Actions workflow is updated to explicitly fetch and validate the current issue labels before applying new labels, ensuring existing labels are preserved and preventing duplicate or conflicting label assignments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Review: fix(ci): Improve Claude issue triage to preserve existing labelsOverall Assessment: ✅ Approve This is a clean, well-scoped PR that addresses a practical issue with the Claude issue triage workflow. SummaryThe changes add two instructional lines to the workflow prompt:
FeedbackStrengths:
Minor Suggestions (Non-blocking)
Premortem Analysis
Checklist
Verdict: This is a good preventive fix. The changes are sensible and low-risk. Approved! Reviewed by Claude |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 123 123
Lines 9457 9457
Branches 1709 1709
=======================================
Hits 8544 8544
Misses 913 913 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying repomix with
|
| Latest commit: |
bc900d7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fb15ea6.repomix.pages.dev |
| Branch Preview URL: | https://fix-claude-issue-triage-pres.repomix.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/claude-issue-triage.yml (1)
47-47: Consider clarifying "conflicting labels".The instruction to "avoid adding duplicate or conflicting labels" is good, but "conflicting labels" is somewhat ambiguous. Consider providing examples or clearer criteria for what constitutes a conflict (e.g., should "bug" and "enhancement" be considered conflicting?). This would help Claude make more consistent decisions.
🔎 Suggested clarification
- - Check if the issue already has any labels applied and avoid adding duplicate or conflicting labels + - Check if the issue already has any labels applied and avoid adding duplicate labels (labels that are already present)Or if you want to maintain the "conflicting" concept, provide examples:
- - Check if the issue already has any labels applied and avoid adding duplicate or conflicting labels + - Check if the issue already has any labels applied and avoid adding duplicate labels (e.g., don't add "bug" if it already exists, and don't add mutually exclusive category labels)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/claude-issue-triage.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Build and run (windows-latest, 20.x)
- GitHub Check: Build and run (windows-latest, 25.x)
- GitHub Check: Test (windows-latest, 24.x)
- GitHub Check: Test with Bun (windows-latest, latest)
- GitHub Check: Test (windows-latest, 22.x)
- GitHub Check: Test with Bun (macos-latest, latest)
- GitHub Check: Test (windows-latest, 25.x)
- GitHub Check: Build and run (macos-latest, 25.x)
- GitHub Check: Test (windows-latest, 20.x)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
.github/workflows/claude-issue-triage.yml (1)
72-72: Good safeguard to preserve existing labels.This instruction explicitly prevents Claude from removing existing labels, which aligns well with the PR objectives. The
--add-labelflag on line 71 appends labels by default without removing existing ones, so this instruction serves as an additional safeguard.
Improve the Claude issue triage workflow to better handle existing labels:
Checklist
npm run testnpm run lint(No code changes, only workflow prompt updates)