Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed span to div in ui elements #3489

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Changed span to div in ui elements #3489

merged 2 commits into from
Nov 16, 2024

Conversation

hirotomoyamada
Copy link
Member

Description

Changed span to div in ui elements.

Is this a breaking change (Yes/No):

No

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
yamada-ui ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2024 2:05pm

@hirotomoyamada hirotomoyamada self-assigned this Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.95%. Comparing base (64b227a) to head (acb0874).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3489   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files        2016     2016           
  Lines       59357    59357           
  Branches     5754     5754           
=======================================
  Hits        58146    58146           
  Misses       1196     1196           
  Partials       15       15           
Files with missing lines Coverage Δ
packages/components/checkbox/src/checkbox.tsx 96.26% <100.00%> (ø)
packages/components/radio/src/radio.tsx 96.40% <100.00%> (ø)
packages/components/switch/src/switch.tsx 100.00% <100.00%> (ø)

@hirotomoyamada hirotomoyamada added the review wanted Need review label Nov 16, 2024
Copy link
Member

@taroj1205 taroj1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@hirotomoyamada hirotomoyamada added the merge request Request approval from codeowners label Nov 16, 2024
Itsuki54

This comment was marked as duplicate.

@hirotomoyamada hirotomoyamada merged commit 9079a2b into main Nov 16, 2024
7 checks passed
@hirotomoyamada hirotomoyamada deleted the fix/span-to-div branch November 16, 2024 14:13
@github-actions github-actions bot mentioned this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge request Request approval from codeowners review wanted Need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants