feat: enhance Icon component a11y #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
kurakke
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3287 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 2015 2015
Lines 46923 46927 +4
Branches 5693 5693
=======================================
+ Hits 45680 45684 +4
Misses 1228 1228
Partials 15 15
|
108yen
requested changes
Oct 30, 2024
bearone236
previously approved these changes
Oct 30, 2024
kurakke
force-pushed
the
feat/a11y/icon
branch
from
05a8707 to
b149e64
Compare
108yen
previously approved these changes
Oct 30, 2024
kurakke
force-pushed
the
feat/a11y/icon
branch
from
b149e64 to
5430cd2
Compare
kurakke
force-pushed
the
feat/a11y/icon
branch
from
5430cd2 to
2f10ba6
Compare
hirotomoyamada
approved these changes
Nov 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3253
Description
Enhanced a11y in the Icon component by setting role="img" and applying aria-hidden="true" as defaults.
Is this a breaking change (Yes/No):
No