Skip to content

Update renderHook usage and types #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Update renderHook usage and types #2778

merged 2 commits into from
Sep 11, 2024

Conversation

hirotomoyamada
Copy link
Member

Closes #2777
Closes #2774

Description

Update renderHook usage and types.

Is this a breaking change (Yes/No):

No

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
yamada-ui ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 9:45pm

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (b0c462e) to head (254f93c).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2778   +/-   ##
=======================================
  Coverage   97.57%   97.58%           
=======================================
  Files        1968     1968           
  Lines       48572    48572           
  Branches     5424     5405   -19     
=======================================
+ Hits        47395    47399    +4     
+ Misses       1160     1156    -4     
  Partials       17       17           

see 5 files with indirect coverage changes

@hirotomoyamada hirotomoyamada added the merge request Request approval from codeowners label Sep 11, 2024
@hirotomoyamada hirotomoyamada merged commit c7778eb into main Sep 11, 2024
7 checks passed
@hirotomoyamada hirotomoyamada deleted the feat/render-hook branch September 11, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge request Request approval from codeowners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add withProvider to renderHook. The a11y in @yamada-ui/test disables withProvider by default.
2 participants