Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary comment #1001

Merged

Conversation

suzukisan22
Copy link
Contributor

Closes #980

Description

Remove Unnecessary comment

Is this a breaking change (Yes/No):

No

Copy link
Member

@taroj1205 taroj1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (d100cab) to head (f170dd5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
- Coverage   87.17%   87.17%   -0.01%     
==========================================
  Files         388      388              
  Lines       55390    55385       -5     
  Branches     3230     3230              
==========================================
- Hits        48286    48281       -5     
  Misses       7079     7079              
  Partials       25       25              
Files Coverage Δ
packages/components/button/src/icon-button.tsx 100.00% <ø> (ø)
Components Coverage Δ
cli 0.00% <ø> (ø)
components 88.35% <ø> (-0.01%) ⬇️
core 95.33% <ø> (ø)
hooks 67.04% <ø> (ø)
providers 95.09% <ø> (ø)
react 100.00% <ø> (ø)
theme-tools 46.38% <ø> (ø)
utils 84.24% <ø> (ø)

@hirotomoyamada hirotomoyamada merged commit 53105f6 into yamada-ui:main Mar 17, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconButton contains unnecessary code
3 participants