Build with -strict-sequence #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This is currently failing with some errors in the testsuite, but I'm happy to merge once those are fixed. |
Armael
force-pushed
the
strict-sequence
branch
from
3c28615
to
a7189b3
Compare
|
I think I fixed the testsuite (the failure on android looks unrelated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
-strict-sequenceand allows building ctypes with it enabled.This is related to the proposal of enabling -strict-sequence by default in ocaml/ocaml#1971, in order to make ctypes forward compatible.
(I can restrict the PR to the change in
commands.mliif you would rather avoid modifying the build instructions themselves; although enabling the option there makes sure the issue will not come back later).