Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print typedefed enums correctly #547

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Print typedefed enums correctly #547

merged 2 commits into from
Oct 3, 2017

Conversation

lpw25
Copy link
Contributor

@lpw25 lpw25 commented Oct 2, 2017

Apparently ctypes sometimes prints references to typedefed enums as enum foo instead of foo. This patch tries to fix this. I haven't personally tested it, but I believe that it has been tested elsewhere within Jane Street.

@yallop
Copy link
Owner

yallop commented Oct 3, 2017

Thanks; this looks good to me. ba09286 adds a test that fails on master but passes with this PR.

@yallop yallop merged commit b3b7ca2 into yallop:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpw25 @yallop