Move Cstubs_internals and FOREIGN from cstubs to ctypes #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the interfaces used to write bindings that generate stubs (
Cstubs.FOREIGN
), the module that supports generated stubs (Cstubs_internals
) and the functions that generate stubs (Cstubs.write_ml
etc.) are all part of the same package (ctypes.stubs
). Consequently, generated code depends on thectypes.cstubs
package, which sometimes causes problems (#519), sincectypes.cstubs
depends onstr
.This PR moves
Cstubs.FOREIGN
andCstubs_internals
from thectypes.stubs
package to thectypes
package, so that generated code no longer depends onctypes.stubs
. The change is backwards-compatible, so existing code should continue to work without any changes. However, if you'd like to eliminate the runtime dependency onctypes.stubs
then you can change the path of theFOREIGN
interface in theBindings
functor to refer toCtypes
rather thanCstubs
, as follows.Existing way of writing bindings:
Writing bindings without the runtime
ctypes.stubs
dependency:This PR addresses some of #528, but additional (and similar) work is still needed to move the
TYPES
interface fromctypes.stubs
toctypes
.