wrap link options passed to ocamlmklib with -ldopt (not -cclib) #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the output of
pkg-config --libs libffi
can contain flags that are not understood by ocamlmklib (like-pthread
).The previous solution ( #428 ) passed the wrong flag to ocamlmklib (
-cclib
instead of-ldopt
), which caused #442 . (-cclib
options are ignored, because ocamlmklib neither calls ocamlc nor ocamlopt at this point, just gcc/ar)