Fix a memory leak with trampoline creation #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs more care to avoid leaking trampolines built from non-closures.
| let keep_alive w ~while_live:v = Gc.finalise (fun _ -> w; ()) v | ||
| let kept_alive_indefinitely = ref [] | ||
| let keep_alive w ~while_live:v = | ||
| try Gc.finalise (fun _ -> w; ()) v |
There was a problem hiding this comment.
Thanks to @yallop for finding this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tie
libfficlosure lifetime to OCaml closure lifetime.