Debian fixes #410
Merged
Debian fixes #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better delimit v's lifetime with a local block. This is relevant in bytecode.
| @@ -1,5 +1,6 @@ | |||
| .SECONDEXPANSION: | |||
|
|
|||
| BEST:=$(shell if which ocamlopt > /dev/null; then echo native; else echo byte; fi) | |||
There was a problem hiding this comment.
Could the which be dropped here, like this:
BEST:=$(shell if ocamlopt > /dev/null; then echo native; else echo byte; fi)
?
Some systems, such as NixOS, apparently don't include which by default, and I'd rather avoid adding another opam dependency.
There was a problem hiding this comment.
In shell, it seems that the error message in case of a missing command is printed on stderr. So the following is better (tested with bash and dash):
BEST:=$(shell if ocamlopt > /dev/null 2>&1; then echo native; else echo byte; fi)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a branch that fixes compilation and tests on all Debian release architectures.