migrate to nnbd #44
migrate to nnbd #44
Conversation
|
Any plans to move forward with this soon, @yadaniyil? |
|
Hi, @miDeb We plan to do it next week. |
|
Thanks @RusKryzhanovskiy, very cool! I have just changed the version in |
|
Hi looking forward to this update! Since flutter has make null safety stable today! |
|
👀 |
|
I resolved the conflicts, this is ready to be reviewed. |
| @@ -21,25 +21,25 @@ class BadgePosition { | |||
|
|
|||
| /// Factory method that creates a new instance of this widget | |||
| /// according to [top] and [start] | |||
| factory BadgePosition.topStart({double? top, double? start}) { | |||
| return BadgePosition(top: top ?? -5, start: start ?? -10); | |||
| factory BadgePosition.topStart({double top = -5, double start = -10}) { | |||
There was a problem hiding this comment.
Is it intentional that top has a default value of -5? It looks like all other defaults for top and bottom are -8.
Deprecated & ignored per dart-lang/pub#2780
|
Can someone merge it soon please? |
|
Would be great to have a null safe version / this PR merged ASAP! |
|
Could you please merge this PR? |
|
Hi, i don't want to press too much but this is one of the last packages blocking me from migrating to Flutter 2 with null safety myself. The PR looks pretty good. Could you maybe at least publish it as a preview version? Thanks! |
|
It should be available at 0.0.3-nullsafety.0.
Let me know if that doesn't work!
…On Sat, Mar 13, 2021 at 10:37 AM Felix Gabler ***@***.***> wrote:
Hi, i don't want to press too much but this is one of the last packages
blocking me from migrating to Flutter 2 with null safety myself. The PR
looks pretty good. Could you maybe at least publish it as a preview
version? Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQX6SNAHP5CR3H6LIIYK3TDOWH3ANCNFSM4W2HMFKA>
.
|
|
It's not listed on the pub.dev page for me. I'll try it in my code later and let you know if that works! Thanks tho! |
I'm confused. Are you sure we're talking about the right package? The latest non-nullsafe version is |
|
Guys, I'll merge the PR and deploy the package as prerelease in 10 minutes. Sorry for being so slow :) |
|
Hi everyone! The package is prereleased. Please let me know if everything works as expected. |
omg, I saw this email on my phone the same morning I'd released a null-safe version of one of my packages and chatted with people about it, and I thought this was for that 😆 Congrats to @yadaniyil for landing this! |
This migrates
flutter_badgesto null safety. You could release apre-releaseversion with this change to pub.dev.