Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to return maps and strings as binaries #23

Closed
fenollp opened this issue Oct 9, 2017 · 6 comments
Closed

Add options to return maps and strings as binaries #23

fenollp opened this issue Oct 9, 2017 · 6 comments
Assignees
@dumbbell
Labels
enhancement
Milestone
v0.6.0

Comments

@fenollp
Copy link
Contributor

fenollp commented Oct 9, 2017

No description provided.

@fenollp
Copy link
Contributor Author

fenollp commented Nov 27, 2017

Found the str_node_as_binary option after a while.

Will probably add maps support later on, as that requires some changes to the build system. Also, is this project still alive?

@dumbbell
Copy link
Collaborator

Hi! Yes, it's still alive, I just lack free time to work on real improvements. However, contributions are welcome :-)

dumbbell added a commit that referenced this issue Nov 29, 2017
@dumbbell
yamerl_node_map: Accept option map_node_format
08018c1 
... to choose between proplists and maps. This option can be set to
either `proplist` or `map`.

If `map` is picked, the maps module is used to create the Erlang map. It
allows to keep support for older versions of Erlang.

Fixes #23.
@dumbbell
Copy link
Collaborator

I prepared a patch (see the link above). I only tested it locally with Erlang 19.3 using the existing testsuite. I didn't even try to use that option yet and the testsuite needs new testcases.

@dumbbell dumbbell self-assigned this Nov 29, 2017
@fenollp
Copy link
Contributor Author

fenollp commented Nov 29, 2017

Works like a charm :)

@dumbbell dumbbell mentioned this issue Nov 29, 2017
Merged
@dumbbell
Copy link
Collaborator

Release 0.6.0 was published to Hex.pm.

@fenollp
Copy link
Contributor Author

fenollp commented Nov 29, 2017

Thanks!

@dumbbell dumbbell added this to the v0.6.0 milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dumbbell dumbbell

Labels
enhancement
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
2 participants
@dumbbell @fenollp