bump version to l12 + fix wrapTable definition#901
Closed
danielrona wants to merge 6 commits into
Closed
Conversation
yajra
requested changes
Feb 25, 2025
Author
|
ok found some things I still have to fix for some wild reasons this escaped me yesterday |
Author
|
seems like the API Docs got updated and alot of functions are now missing while some others are deprecated not entirely sure why the tests passed yesterday or if I just had a stale composer cache but will Update if I can find some more time for it. |
Owner
|
Thanks, it seems like a lot of changes in the API structure. #902 |
Author
|
yes, I had most of the stuff in my fork already working just the tests with the prefix were failing but didn't had a chance to get around it yet but seems yours mostly fixed that. I'll go test that tomorrow morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bumped the version constraint to v12 for laravel
added the required API Change only found wrapTable added $prefix = null