Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve schema grammar #842

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

fagundes
Copy link

@fagundes fagundes commented Apr 1, 2024

Goal:

  • Be able to use correctly project barryvdh/laravel-ide-helper, especially command php artisan ide-helper:models with oracle

Improves:

  • change compileColumns
  • add compileForeignKeys
  • add and change tests
  • improve getColumns / compileColumns, before it was possible getColumns only on user schema, now it possible retrieve columns from others schemas

Possible break change:

  • change compileColumns fields:
    • string fields (like column name, column type) to lower case;
    • nullable to boolean;
    • numeric fields (like length) to int;
    • change type value based on precision and scale;
    • change length value based on type;

@fagundes fagundes force-pushed the fagundes/grammar-for-ide-helper branch from efdf746 to 0379466 Compare April 1, 2024 23:42
@yajra yajra self-requested a review April 2, 2024 02:35
@yajra
Copy link
Owner

yajra commented Apr 2, 2024

Thank you for the PR, will review this as soon as I can.

@yajra yajra changed the title improve schema grammar feat: Improve schema grammar Apr 2, 2024
@yajra yajra merged commit 773580c into yajra:master Apr 11, 2024
2 checks passed
@yajra
Copy link
Owner

yajra commented Apr 11, 2024

Released on v11.1.0 🚀 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants