Compatibility with DataTables 1.13's ES modules #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that DataTables provides ES modules, Vite will automatically use them rather than the UMD files. However, the signature of the ESM files is slightly different from the CommonJS loader that was used before. We no longer need to execute a function - it is just present automatically from the import. I've also shortened the setting of how the default properties are set. It does exactly the same thing.
|
Hi @AllanJard, Thanks for the patch, appreciate it! Learned something new here. Tested on Quick Starter and all working well now. Released on v0.5.0 🚀 Regards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that DataTables provides ES modules, Vite will automatically use them rather than the UMD files. However, the signature of the ESM files is slightly different from the CommonJS loader that was used before. We no longer need to execute a function - it is just present automatically from the import.
I've also shortened the setting of how the default properties are set. It does exactly the same thing.