Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): fixed stopped checking #3

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(node): fixed stopped checking #3

merged 1 commit into from
Mar 19, 2024

Conversation

cnlangzi
Copy link
Member

Fixes

  • fixed Stopped checking

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

General suggestions:

  • Consider further simplification of the node lifecycle management to enhance maintainability.
  • Review the new lease management methods for potential edge cases or improvements.
  • Ensure that the removal of context from certain methods does not impact the system's ability to handle cancellations or timeouts effectively.
Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

mutext_test.go Outdated Show resolved Hide resolved
node_svc.go Outdated Show resolved Hide resolved
node_svc.go Outdated Show resolved Hide resolved
lease.go Outdated Show resolved Hide resolved
Copy link

deepsource-io bot commented Mar 19, 2024

Here's the code health analysis summary for commits 859cd85..cd5458d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.20%. Comparing base (859cd85) to head (cd5458d).

Files Patch % Lines
node_svc.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   85.78%   87.20%   +1.42%     
==========================================
  Files           9        9              
  Lines         422      422              
==========================================
+ Hits          362      368       +6     
+ Misses         40       35       -5     
+ Partials       20       19       -1     
Flag Coverage Δ
Unit-Tests 87.20% <60.00%> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnlangzi cnlangzi merged commit 0f2a8d1 into main Mar 19, 2024
6 of 8 checks passed
@cnlangzi cnlangzi deleted the fix/node_svc branch March 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant