Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): added tests for Mutex #2

Merged
merged 6 commits into from
Mar 19, 2024
Merged

fix(tests): added tests for Mutex #2

merged 6 commits into from
Mar 19, 2024

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Mar 19, 2024

Fixes

  • added tests for Mutex

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

General suggestions:

  • Consider reviewing the error handling strategy to ensure consistency and clarity across the system.
  • Evaluate the impact of the changes on the system's performance, particularly in high-load scenarios.
  • Ensure that the new logic integrates seamlessly with existing components and does not introduce regressions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 87.57062% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 85.78%. Comparing base (75bf8a9) to head (47acd96).

Files Patch % Lines
mutex.go 86.57% 13 Missing and 7 partials ⚠️
node_svc.go 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   70.02%   85.78%   +15.75%     
===========================================
  Files           9        9               
  Lines         337      422       +85     
===========================================
+ Hits          236      362      +126     
+ Misses         86       40       -46     
- Partials       15       20        +5     
Flag Coverage Δ
Unit-Tests 85.78% <87.57%> (+15.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

deepsource-io bot commented Mar 19, 2024

Here's the code health analysis summary for commits 75bf8a9..47acd96. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cnlangzi cnlangzi changed the title fix(tests): added tests for Renew fix(tests): added tests for Mutex Mar 19, 2024
@cnlangzi cnlangzi merged commit 859cd85 into main Mar 19, 2024
8 checks passed
@cnlangzi cnlangzi deleted the fix/mutex_tests branch March 19, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant