Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): used sql instead raft as store #1

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix(node): used sql instead raft as store #1

merged 2 commits into from
Mar 19, 2024

Conversation

cnlangzi
Copy link
Member

Changes

  • used sql instead of raft as storage

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

General suggestions:

  • Consider adding more detailed logging around critical operations such as lock acquisition, renewal, and release to aid in debugging and monitoring.
  • Review the error handling strategy to ensure consistency and clarity in error messages returned from different operations.
  • Evaluate the performance implications of the switch to SQL-based storage, especially in high-concurrency scenarios, to ensure that the system can maintain its responsiveness and reliability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Mar 19, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

deepsource-io bot commented Mar 19, 2024

Here's the code health analysis summary for commits dccf187..7892e72. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ Success
🎯 1 occurence resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cnlangzi cnlangzi merged commit 75bf8a9 into main Mar 19, 2024
8 checks passed
@cnlangzi cnlangzi deleted the feat/db branch March 19, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant