chore(devops): fixed deepsource warnings

yaitoo · Mar 18, 2024 · d4b90f7 · d4b90f7
1 parent 8daaec1
commit d4b90f7
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 257 deletions.
diff --git a/.gitignore b/.gitignore
@@ -15,7 +15,8 @@ snapshots
 
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
-
+coverage.txt
+__debug_bin*
 
 # Dependency directories (remove the comment below to include it)
 # vendor/

diff --git a/cluster.go b/cluster.go
@@ -91,7 +91,7 @@ func (c *Cluster) Join(ctx context.Context, p Peer) error {
 
 	_, err := a.WaitAny(ctx)
 
-	if err != nil && !exists {
+	if err == nil && !exists {
 		c.peers = append(c.peers, p)
 	}
 

diff --git a/conn.go b/conn.go
@@ -47,8 +47,3 @@ func (c *Conn) Write(p []byte) (n int, err error) {
 	go c.wait()
 	return c.Conn.Write(p)
 }
-
-func (c *Conn) Close() error {
-	go c.wait()
-	return c.Conn.Close()
-}
diff --git a/coverage.txt b/coverage.txt
diff --git a/node_svc.go b/node_svc.go
@@ -114,7 +114,6 @@ func (n *Node) waitRequest(l net.Listener) {
 }
 
 func (n *Node) waitClose(ctx context.Context, l net.Listener) {
-	defer l.Close()
-
 	<-ctx.Done()
+	l.Close()
 }
diff --git a/snapshot.go b/snapshot.go
@@ -37,4 +37,4 @@ func (s *snapshot) Persist(sink raft.SnapshotSink) error {
 	return err
 }
 
-func (s *snapshot) Release() {}
+func (_ *snapshot) Release() {}