Improve perf via isJSON option
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some micro-optimizations along with a new macro
optimization: `{isJSON: true}` option.
Passing a `replacer` function to `JSON.stringify()` slows it down
dramatically. If possible, we should avoid this this path, and the
new `isJSON` option is the signal that the object passed-in contains
no functions or regexp values.
Node v0.12.10
simpleObj:
JSON.stringify( simpleObj ) x 1,303,349 ops/sec ±0.66% (99 runs sampled)
JSON.stringify( simpleObj ) with replacer x 386,634 ops/sec ±0.72% (96 runs sampled)
serialize( simpleObj ) x 284,535 ops/sec ±0.92% (98 runs sampled)
**serialize( simpleObj, {isJSON: true} ) x 951,798 ops/sec ±0.92% (96 runs sampled)**
|
CLA is valid! |
Closed
|
Might want to re-think the name of the option given #16 would require the replacer function. |
|
👍 |
ericf
added a commit
to YahooArchive/express-state
that referenced
this pull request
May 26, 2016
This adds support for the forthcoming `isJSON` option being added to `serialize-javascript` to help speed up serialization for pure JSON data. yahoo/serialize-javascript#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some micro-optimizations along with a new macro optimization:
{isJSON: true}option.Passing a
replacerfunction toJSON.stringify()slows it down dramatically. If possible, we should avoid this this path, and the newisJSONoption is the signal that the object passed-in contains no functions or regexp values. But still protect against XSS by properly escaping for a<script>context.