Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: update gridstack to v4.x #82

Merged
merged 13 commits into from
Oct 19, 2021
Merged

Conversation

kevinhinterlong
Copy link
Member

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@kevinhinterlong kevinhinterlong marked this pull request as ready for review June 24, 2021 16:17
addon/components/grid-stack.hbs Outdated Show resolved Hide resolved
addon/components/grid-stack.hbs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@btecu
Copy link
Contributor

btecu commented Jul 2, 2021

Can you check if #67 is fixed?

@kevinhinterlong
Copy link
Member Author

Can you check if #67 is fixed?

@btecu added a test and @jkusa added a changelog plus bumped the version

Copy link
Member

@jkusa jkusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kevinhinterlong kevinhinterlong added the blocked Blocked label Jul 12, 2021
@scottfisk
Copy link

Hello! I have been playing around with this library and noticed version 2.1.0 does not support animations due to a bug in gridstack version 1.x.x. It appears that this branch does support animations as it is based on a much newer version of gridstack.

Is there a reason this PR has not been merged? I see the blocked tag with no explanation. Would it be safe to use this branch until it is fully merged and released or is there some known issue with it?

Thanks for all the work on integrating this library with ember!

@Shadowninja33
Copy link

@kevinhinterlong Would it be possible to get an update on why this PR was labeled as blocked? This add-on definitely fills a huge hole in the ember ecosystem and it would be great to get it updated to the latest gridstack version.

@kevinhinterlong kevinhinterlong removed the blocked Blocked label Oct 14, 2021
@kevinhinterlong
Copy link
Member Author

@jkusa Should be ready for another review. Mostly just updated the docs/changelog, but we should probably make an issue to unpin socket.io once socketio/socket.io#4121 is resolved

@kevinhinterlong kevinhinterlong changed the title feat: update to latest gridstack BREAKING CHANGE: update gridstack to v4.x Oct 19, 2021
@kevinhinterlong kevinhinterlong merged commit df7e0b1 into master Oct 19, 2021
@kevinhinterlong kevinhinterlong deleted the latest-gridstack branch October 19, 2021 16:28
kevinhinterlong pushed a commit that referenced this pull request Oct 19, 2021
BREAKING CHANGE: update gridstack to v4.x (#82)
jkusa pushed a commit that referenced this pull request Oct 19, 2021
BREAKING CHANGE: update gridstack to v4.x (#82)
@yavin-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kevinhinterlong kevinhinterlong linked an issue Oct 23, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glimmer actions broken
6 participants