Add support for Swift Package Manager #8
Conversation
|
Seems like Travis fails because of a Podspec listing error. That is unrelated to this PR though, I did not make any changes to the podspec. |
| @@ -305,13 +306,13 @@ public extension YMTreeMap { | |||
| } | |||
| } | |||
|
|
|||
| internal extension YMTreeMap.Rect { | |||
| extension YMTreeMap.Rect { | |||
There was a problem hiding this comment.
Ah, what’s the right way to do this now? Ideally public APIs are minimized because they’re contracts. But this is very minor.
There was a problem hiding this comment.
I merely removed the access modifiers on the extensions because they are redundant. The properties and functions inside the extensions already specify their access level. This just fixes a compiler warning, there is no actual change to the access levels.
Looks like the version of Cocoapods no longer supports swift_version field |
Change `swift_version` to `swift_versions`
|
Yes I would. I will ping some contacts at Yahoo as they removed all former
employees ability to merge approved PRs to their own repos a few months ago.
On Sat, Jun 17, 2023 at 06:12 Ward van Teijlingen ***@***.***> wrote:
Looks like the version of Cocoapods no longer supports swift_version field
Indeed. And it also seems to be unable to find the specified iPhone
simulator:
xcodebuild: error: SDK "iphonesimulator10.2" cannot be located.
Would you be willing to accept a PR that updates this package to some more
up to date versions such as Swift5 and Xcode 14?
—
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRXEJ4GULLPXN5ZLX37HTXLV7IDANCNFSM6AAAAAAZGC7YRQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
…-adam
|
This PR adds support for Swift Package Manager by adding a Package.swift file
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.