Terra base classes integration#1
Merged
Merged
Conversation
# Conflicts: # qiskit_experiments/analysis/plotting.py # qiskit_experiments/base_experiment.py # qiskit_experiments/composite/composite_analysis.py # qiskit_experiments/randomized_benchmarking/interleaved_rb_analysis.py # qiskit_experiments/randomized_benchmarking/rb_analysis.py # test/test_t1.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@yaelbh I got access denied when trying to push to your branch, so here's a PR instead. The main changes I did were
AnalysisResultclass since it was just a dictionary. Places that used it now just usedict_run_analysis()methods now returnAnalysisResultV1. I debated about whether to have_run_analysisreturn a dictionary (result data) instead, and just have therun()method inBaseAnalysisconstructs the actualAnalysisResultV1object. Butrun()might not have all the information needed if_run_analysis()returns multiple analysis.experiment.run()non blocking.All T1 tests work now. I didn't test other classes since there are no test cases for them.
Details and comments