Add custom tags to existing metrics. #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envek
reviewed
Aug 5, 2020
Add the custom tags to existing metrics by retrieving them from the payload.
|
@Envek added a simple example. |
|
Thank you! Released in v0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Envek
This is a small improvement to use the custom tags on existing metrics for Rails.
This should work well with
append_info_to_payloadfrom Rails. https://api.rubyonrails.org/classes/ActionController/Instrumentation.html#method-i-append_info_to_payloadI'd like to hear your thoughts on it.
I tested it only with Rails 6.0.3.2.
Best,