Skip to content

ci: Use Apple Clang 16 to support C++20 on macOS 14; Drop support for Ubuntu 20.04. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirkrodrigues merged 13 commits into from
Feb 26, 2025
Merged

ci: Use Apple Clang 16 to support C++20 on macOS 14; Drop support for Ubuntu 20.04. #29

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e7c852f
Update macos-14 to use clang-16 and update OS choices for linting
Bill-hbrhbr Feb 25, 2025
b2ab238
Drop Ubuntu 20.04. Use workflow env vars
Bill-hbrhbr Feb 25, 2025
0584173
Test removing installing coreutils
Bill-hbrhbr Feb 25, 2025
55e7f61
Add back md5sum for macos14
Bill-hbrhbr Feb 25, 2025
6f6acc6
Fix bug
Bill-hbrhbr Feb 25, 2025
920ca5e
Use ternery operator
Bill-hbrhbr Feb 25, 2025
dc895ed
Style fix
Bill-hbrhbr Feb 25, 2025
5e40ed1
Apply suggestions from code review
Bill-hbrhbr Feb 25, 2025
c258588
Address code review
Bill-hbrhbr Feb 25, 2025
bef12df
Rename step
Bill-hbrhbr Feb 25, 2025
549e1cf
Fix yaml
Bill-hbrhbr Feb 25, 2025
22d3089
Try solution
Bill-hbrhbr Feb 25, 2025
da15730
Update .github/workflows/unit-tests.yaml
Bill-hbrhbr Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions .github/workflows/code-linting-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
strategy:
matrix:
os:
- "macos-latest"
- "ubuntu-latest"
- "macos-15"
- "ubuntu-24.04"
runs-on: "${{matrix.os}}"
steps:
- uses: "actions/checkout@v4"
Expand All @@ -37,17 +37,6 @@ jobs:
shell: "bash"
run: "npm install -g @go-task/cli"

- if: "matrix.os == 'macos-latest'"
name: "Install coreutils (for md5sum)"
run: "brew install coreutils"

- name: "Log tool versions"
run: |-
md5sum --version
python --version
tar --version
task --version

- name: "Run lint task"
shell: "bash"
run: "task lint:check"
37 changes: 15 additions & 22 deletions .github/workflows/unit-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
strategy:
matrix:
os:
- "macos-latest"
- "ubuntu-20.04"
- "macos-14"
- "macos-15"
- "ubuntu-22.04"
- "ubuntu-24.04"
runs-on: "${{matrix.os}}"
Expand All @@ -39,27 +39,20 @@ jobs:
shell: "bash"
run: "npm install -g @go-task/cli"

- if: "matrix.os == 'macos-latest'"
name: "Install coreutils (for md5sum)"
run: "brew install coreutils"

- if: "matrix.os == 'ubuntu-20.04'"
name: "Install gcc-10 (for c++20)"
run: |-
sudo apt-get update
sudo DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \
g++-10 \
gcc-10
sudo ln --symbolic --force /usr/bin/gcc-10 /usr/bin/cc
sudo ln --symbolic --force /usr/bin/g++-10 /usr/bin/c++
sudo ln --symbolic --force /usr/bin/cpp-10 /usr/bin/cpp

- name: "Log tool versions"
- if: "'macos-14' == matrix.os"
name: "Install MacOS 14 deps: coreutils (for md5sum) and Apple Clang 16 (for C++20)"
Comment thread
Bill-hbrhbr marked this conversation as resolved.
Outdated
run: |-
command -v md5sum
command -v python
command -v tar
command -v task
brew install coreutils
brew install llvm@16

- name: "Run unit tests"
env: >-
${{
'macos-14' == matrix.os
&& fromJson('{
"CC": "/opt/homebrew/opt/llvm@16/bin/clang",
"CXX": "/opt/homebrew/opt/llvm@16/bin/clang++"
}')
|| fromJson('{}')
}}
run: "task test-all"